Re: [PATCH] mmc: mmc_spi: remove unnecessary check in mmc_spi_setup_data_message()

[Ulf Hansson]

On Thu, 21 Aug 2025 at 14:32, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
>
> An earlier commit changed the outer if statement from
> "if (multiple || write) {" to "if (write) {" so now we know that "write"
> is true and no longer need to check.  Delete the unnecessary check.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

Applied for next, thanks!

Kind regards
Uffe


> ---
>  drivers/mmc/host/mmc_spi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/mmc_spi.c b/drivers/mmc/host/mmc_spi.c
> index 95a32ff29ee1..42936e248c55 100644
> --- a/drivers/mmc/host/mmc_spi.c
> +++ b/drivers/mmc/host/mmc_spi.c
> @@ -566,7 +566,7 @@ mmc_spi_setup_data_message(struct mmc_spi_host *host, bool multiple, bool write)
>         if (write) {
>                 t = &host->early_status;
>                 memset(t, 0, sizeof(*t));
> -               t->len = write ? sizeof(scratch->status) : 1;
> +               t->len = sizeof(scratch->status);
>                 t->tx_buf = host->ones;
>                 t->rx_buf = scratch->status;
>                 t->cs_change = 1;
> --
> 2.47.2
>