RE: [PATCH v2 02/10] clk: samsung: Add clock PLL support for ARTPEC-8 SoC

From: Ravi Patel
Date: Fri Aug 22 2025 - 08:10:13 EST




> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> Sent: 22 August 2025 12:02
> To: Ravi Patel <ravi.patel@xxxxxxxxxxx>; jesper.nilsson@xxxxxxxx; mturquette@xxxxxxxxxxxx; sboyd@xxxxxxxxxx;
> robh@xxxxxxxxxx; krzk+dt@xxxxxxxxxx; conor+dt@xxxxxxxxxx; s.nawrocki@xxxxxxxxxxx; cw00.choi@xxxxxxxxxxx;
> alim.akhtar@xxxxxxxxxxx; linus.walleij@xxxxxxxxxx; tomasz.figa@xxxxxxxxx; catalin.marinas@xxxxxxx; will@xxxxxxxxxx;
> arnd@xxxxxxxx
> Cc: ksk4725@xxxxxxxxxx; kenkim@xxxxxxxxxx; pjsin865@xxxxxxxxxx; gwk1013@xxxxxxxxxx; hgkim05@xxxxxxxxxx;
> mingyoungbo@xxxxxxxxxx; smn1196@xxxxxxxxxx; pankaj.dubey@xxxxxxxxxxx; shradha.t@xxxxxxxxxxx;
> inbaraj.e@xxxxxxxxxxx; swathi.ks@xxxxxxxxxxx; hrishikesh.d@xxxxxxxxxxx; dj76.yang@xxxxxxxxxxx;
> hypmean.kim@xxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-samsung-
> soc@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxx; linux-clk@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux-
> gpio@xxxxxxxxxxxxxxx; soc@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH v2 02/10] clk: samsung: Add clock PLL support for ARTPEC-8 SoC
>
> On 21/08/2025 14:32, Ravi Patel wrote:
> > +
> > +static const struct clk_ops samsung_pll1031x_clk_ops = {
> > + .recalc_rate = samsung_pll1031x_recalc_rate,
> > + .round_rate = samsung_pll_round_rate,
>
>
> This will conflict with round_rate drop, so might need rebasing. Please
> follow up discussion or decisions in the round rate patchset.

Thanks for review. Yes, I can see conflicts with below patch
https://lore.kernel.org/linux-samsung-soc/20250811-clk-for-stephen-round-rate-v1-99-b3bf97b038dc@xxxxxxxxxx/

Since merging strategy of round_rate patches are not clear as of now, will wait for couple of days before posting v3.
Request to review other patches also.

Thanks,
Ravi

>
> Best regards,
> Krzysztof