Re: [PATCH] nvmet-fc: move lsop put work to nvmet_fc_ls_req_op

[Hannes Reinecke]

On 8/21/25 14:48, Daniel Wagner wrote:
> It’s possible for more than one async command to be in flight from
> __nvmet_fc_send_ls_req. For each command, a tgtport reference is taken.
>
> In the current code, only one put work item is queued at a time, which
> results in a leaked reference.
>
> To fix this, move the work item to the nvmet_fc_ls_req_op struct, which
> already tracks all resources related to the command.
>
> Fixes: 710c69dbaccd ("nvmet-fc: avoid deadlock on delete association path")
> Signed-off-by: Daniel Wagner <wagi@xxxxxxxxxx>
> ---
>   drivers/nvme/target/fc.c | 19 +++++++++----------
>   1 file changed, 9 insertions(+), 10 deletions(-)
Reviewed-by: Hannes Reinecke <hare@xxxxxxx>

Cheers,

Hannes
--
Dr. Hannes Reinecke                  Kernel Storage Architect
hare@xxxxxxx                                +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich