Re: [PATCH] edac/amd76x: Remove assignment from if condition in amd76x_remove_one()

From: Borislav Petkov
Date: Fri Aug 22 2025 - 10:54:25 EST


On Tue, Aug 12, 2025 at 06:31:54PM +0530, darshanrathod475@xxxxxxxxx wrote:
> From: Darshan Rathod <darshanrathod475@xxxxxxxxx>
>
> The code was performing an assignment inside the if condition:
>
> if ((mci = edac_mc_del_mc(&pdev->dev)) == NULL)
>
> This triggers a checkpatch.pl warning.

And?

Is this a bug or just something some silly script is telling you to do?

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette