Re: [PATCH v8 4/5] iio: mcp9600: Recognize chip id for mcp9601

[Andy Shevchenko]

On Fri, Aug 22, 2025 at 4:24 PM Ben Collins <bcollins@xxxxxxxxxx> wrote:
>
> The current driver works with mcp9601, but emits a warning because it
> does not recognize the chip id.
>
> MCP9601 is a superset of MCP9600. The drivers works without changes
> on this chipset.
>
> However, the 9601 chip supports open/closed-circuit detection if wired
> properly, so we'll need to be able to differentiate between them.
>
> Moved "struct mcp9600_data" up in the file since a later patch will
> need it and chip_info before the declarations.

...

> +struct mcp9600_data {
> +       struct i2c_client *client;
> +};
> +

> -struct mcp9600_data {
> -       struct i2c_client *client;
> -};
> -

Seems we discussed this. And my suggestion was to defer the change to
when it will be needed.

...

The rest LGTM.

-- 
With Best Regards,
Andy Shevchenko