Re: [PATCH v4 1/3] net: phy: mxl-86110: add basic support for led_brightness_set op

[Andrew Lunn]

On Fri, Aug 22, 2025 at 06:38:27PM +0100, Daniel Golle wrote:
> Add support for forcing each connected LED to be always on or always off
> by implementing the led_brightness_set() op.
> This is done by modifying the COM_EXT_LED_GEN_CFG register to enable
> force-mode and forcing the LED either on or off.
> When calling the led_hw_control_set() force-mode is again disabled for
> that LED.
> Implement mxl86110_modify_extended_reg() locked helper instead of
> manually acquiring and releasing the MDIO bus lock for single
> __mxl86110_modify_extended_reg() calls.
> 
> Signed-off-by: Daniel Golle <daniel@xxxxxxxxxxxxxx>

Reviewed-by: Andrew Lunn <andrew@xxxxxxx>

    Andrew