RE: [PATCH v2 05/12] media: imx-mipi-csis: Move clk to mipi_csis_info structure

From: Inbaraj E
Date: Sat Aug 23 2025 - 09:11:45 EST



Hi Laurent,

Thanks for the review.

>
> On Thu, Aug 14, 2025 at 07:39:36PM +0530, Inbaraj E wrote:
> > clock names in NXP SoC's is different from the FSD SoC. Inorder to
>
> s/clock/Clock/
> s/Inorder/In order/
>
I'll change in next patchset.

> Is the difference really a matter of SoCs, or is it because the FSD SoC uses a
> different version of the IP ?
>

Yes, it is dependent on the version of the IP. Thanks for pointing it out. I'll update commit
description accordingly.

> I also suspect that the "phy" clock was added by mistake, and isn't needed in
> NXP SoCs. Could you please check and confirm if the v3.3 and
> v3.6.3 versions of the IP have an input PHY clock ?

I don't have manuals for v3.3 and v3.6.3, So I cannot confirm this.

>
> > extend this driver to use for FSD SoC. Move the clock names to
> > mipi_csis_info structure.
> >

Regards,
Inbaraj E