Re: [PATCH v2 3/5] rust: scatterlist: Add type-state abstraction for sg_table
From: Alexandre Courbot
Date: Sat Aug 23 2025 - 09:48:21 EST
Oops, forgot to mention a couple more things:
On Thu Aug 21, 2025 at 1:52 AM JST, Danilo Krummrich wrote:
> Add a safe Rust abstraction for the kernel's scatter-gather list
> facilities (`struct scatterlist` and `struct sg_table`).
>
> This commit introduces `SGTable<T>`, a wrapper that uses a type-state
> pattern to provide compile-time guarantees about ownership and lifetime.
Is this actually a typestate? From my understanding, the typestate
pattern implies transitions from one state to the other (such as
Unmapped -> Mapped), but in this version there are no such transitions
(the previous ones had, though). We are just using a generic parameter,
so mentioning typestate sounds a bit misleading to me.
Another random thought, in the owned case, do we want to provide an
accessor to the provider of the backing pages? Or do we expect the
caller to take dispositions to keep such a reference if they need to
access the backing buffer post-mapping?