Re: [PATCH v8 2/5] dt-bindings: iio: mcp9600: Add microchip,mcp9601 and add constraints
From: David Lechner
Date: Sat Aug 23 2025 - 12:12:15 EST
On 8/23/25 11:06 AM, David Lechner wrote:
> On 8/22/25 8:23 AM, Ben Collins wrote:
...
>> + - |
>> + #include <dt-bindings/iio/temperature/thermocouple.h>
>
> This header isn't used in this example.
>
>> + #include <dt-bindings/interrupt-controller/irq.h>
>> + i2c {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + temperature-sensor@62 {
>> + compatible = "microchip,mcp9601", "microchip,mcp9600";
>> + reg = <0x62>;
>> + interrupt-parent = <&gpio>;
>> + interrupts = <22 IRQ_TYPE_EDGE_RISING>, <23 IRQ_TYPE_EDGE_RISING>;
>> + interrupt-names = "open-circuit", "short-circuit";
>> + vdd-supply = <&vdd>;
>> + microchip,vsense;
>> + };
>> + };
>>
>
> With that fixed:
>
> Reviewed-by: David Lechner <dlechner@xxxxxxxxxxxx>
>
BTW, sometimes Jonathan is nice and fixes a one-line change like this
when applying patches, so don't rush off and send a v9 just quite yet
unless there are other bigger changes that need to be done anyway.