Re: [PATCH RFC v3 04/15] blk-crypto: fix missing processing for split bio

From: Damien Le Moal
Date: Mon Sep 01 2025 - 02:34:50 EST


On 9/1/25 12:32 PM, Yu Kuai wrote:
> From: Yu Kuai <yukuai3@xxxxxxxxxx>
>
> 1) trace_block_split() is missing and blktrace can't catch split events;
> 2) blkcg_bio_issue_init() is missing, and io-latency will not work
> correctly for split bio.
>
> Fixes: 488f6682c832 ("block: blk-crypto-fallback for Inline Encryption")
> Signed-off-by: Yu Kuai <yukuai3@xxxxxxxxxx>

Most comments I sent on patch 3 apply here too.

With that,

Reviewed-by: Damien Le Moal <dlemoal@xxxxxxxxxx>

--
Damien Le Moal
Western Digital Research