Re: [PATCH 3/3] pinctrl: renesas: Use int type to store negative error codes

[Geert Uytterhoeven]

Hi Qianfeng,

On Mon, 1 Sept 2025 at 12:13, Qianfeng Rong <rongqianfeng@xxxxxxxx> wrote:
> 在 2025/9/1 17:07, Geert Uytterhoeven 写道:
> > On Sun, 31 Aug 2025 at 10:50, Qianfeng Rong <rongqianfeng@xxxxxxxx> wrote:
> >> Change the 'ret' variable in ma35_pinctrl_parse_functions() from unsigned
> > sh_pfc_pinconf_group_set
>
> Thank you for pointing out my mistake.
>
> >> int to int, as it needs to store either negative error codes or zero
> >> returned by sh_pfc_pinconf_set().
> >>
> >> No effect on runtime.
> > Fortunately the issue was indeed harmless.
> >
> >> Signed-off-by: Qianfeng Rong <rongqianfeng@xxxxxxxx>
> > Fixes: d0593c363f04ccc4 ("pinctrl: sh-pfc: Propagate errors on group config")
> > Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> > i.e. will queue in renesas-pinctrl for v6.18, with the above fixed.
>
> Will do in the next version.

There is no need to resend; I will fix this up while applying.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds