Re: [PATCH] net: mvpp2: Fix refcount leak in mvpp2_use_acpi_compat_mode

From: Jakub Kicinski
Date: Mon Sep 01 2025 - 15:53:21 EST


On Sat, 30 Aug 2025 17:18:54 +0800 Miaoqian Lin wrote:
> - return (!fwnode_property_present(port_fwnode, "phy-handle") &&
> - !fwnode_property_present(port_fwnode, "managed") &&
> - !fwnode_get_named_child_node(port_fwnode, "fixed-link"));
> + if (fwnode_property_present(port_fwnode, "phy-handle") ||
> + fwnode_property_present(port_fwnode, "managed"))
> + return false;
> +
> + fixed_link = fwnode_get_named_child_node(port_fwnode, "fixed-link");

Wouldn't it be easier to switch to fwnode_get_named_child_node_count() ?
--
pw-bot: cr