Re: [PATCH 08/10] gpu: nova-core: falcon: Add support to check if RISC-V is active

[Alistair Popple]

On 2025-08-30 at 04:48 +1000, Timur Tabi <ttabi@xxxxxxxxxx> wrote...
> On Wed, 2025-08-27 at 18:20 +1000, Alistair Popple wrote:
> > +    pub(crate) fn is_riscv_active(&self, bar: &Bar0) -> Result<bool> {
> > +        let cpuctl = regs::NV_PRISCV_RISCV_CPUCTL::read(bar, &E::ID);
> > +        Ok(cpuctl.active_stat())
> > +    }
> 
> I think this should return just bool instead of Result<bool>

Agreed. And looking at some of the other sequencer/falcon code in Joel's series
I believe similar comments apply there. I assume something changed with the
register reading code to make this possible.