RE: [PATCH v4 net-next 4/5] net: fec: add change_mtu to support dynamic buffer allocation

From: Wei Fang
Date: Mon Sep 01 2025 - 21:29:38 EST


> > > + /* Stop TX/RX and free the buffers */
> > > + napi_disable(&fep->napi);
> > > + netif_tx_disable(ndev);
> > > + read_poll_timeout(fec_enet_rx_napi, done, (done == 0),
> > > + 10, 1000, false, &fep->napi, 10);
> > > + fec_stop(ndev);
> > > +
> > > + WRITE_ONCE(ndev->mtu, new_mtu);
> > > +
> > > + if (fep->pagepool_order != old_order) {
> >
> > If fep->pagepool_order is not changed, why need to stop TX/RX?
> >
>
> The purpose is to update the MAX_FL based on the new mtu.

Thanks for the explanation, it would be better to add a comment here
to make it easier for readers to understand. :)