Re: [PATCH v2 1/9] list: add list_last_entry_or_null()
From: Jani Nikula
Date: Tue Sep 02 2025 - 08:20:52 EST
On Tue, 02 Sep 2025, Luca Ceresoli <luca.ceresoli@xxxxxxxxxxx> wrote:
> Hello DRM maintainers,
>
> On Wed, 20 Aug 2025 16:43:56 +0300
> Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
>
>> On Thu, Aug 14, 2025 at 06:36:09PM +0200, Luca Ceresoli wrote:
>> > On Wed, 6 Aug 2025 00:55:02 +0300
>> > Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
>> >
>> > > On Fri, Aug 01, 2025 at 07:05:23PM +0200, Luca Ceresoli wrote:
>> > > > Add an equivalent of list_first_entry_or_null() to obtain the last element
>> > > > of a list.
>> > >
>> > > Acked-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
>> >
>> > Thanks Andy!
>> >
>> > However I'm not sure when and where this should be applied.
>> >
>> > Except for this one patch, all patches in the series are for
>> > drm-misc-next. Also, patch 1 is currently not needed by any other
>> > series AFAIK.
>> >
>> > Based on the above, is it correct to assume that the whole series can
>> > be applied on drm-misc-next? (when other patches will have a
>> > R-by/Ack-by of course)
>> >
>> > Also, is Andy's A-by enough to apply this patch?
>>
>> The list.h is common for many, I think going via DRM with my Ack is enough
>> based on the Git history of my changes in this file. But if you want more
>> reliable source, get an Ack from Andrew Morton.
>
> While applying this patch with dim on drm-misc-next, dim push-branch
> failed because:
>
> dim: ERROR: cb86408b1fc2 ("list: add list_last_entry_or_null()"): Mandatory Maintainer Acked-by missing., aborting
>
> Looking at the dim code, it is looking for a Reviewed- or Acked-by from
> people listed by `scripts/get_maintainer.pl --no-git-fallback -m --nol
> --norolestats`. but that command returns an empty string, so it will
> never allow me to push.
>
> How can I get that commit pushed to drm-misc-next?
>
> I think `dim push-branch -f` would work: am I supposed to use it?
Try 'dim -f push-branch'. The parameters after push-branch go to git,
and you don't want that.
BR,
Jani.
>
> (not sure my committer rights allow that)
>
> Luca
--
Jani Nikula, Intel