Re: [PATCH v4] iio: light: ltr390: Implement runtime PM support

[Andy Shevchenko]

On Tue, Sep 02, 2025 at 03:57:24PM +0300, Andy Shevchenko wrote:
> On Tue, Sep 02, 2025 at 12:12:36AM +0530, Akshay Jindal wrote:

...

> > +		if (regmap_clear_bits(data->regmap, LTR390_INT_CFG,
> > +					LTR390_LS_INT_EN) < 0)
> 
> Wrong indentation, hard to read line, either one line, or do better. Actually
> why not assign it to ret? The above not only simple style issue, but also makes
> readability much harder as the semantics of '0' is completely hidden. This style
> is discouraged.

Noticing that this is existing style I recommend to have a precursor patch to
fix this and any other place like this first.

-- 
With Best Regards,
Andy Shevchenko