Re: [PATCH] rust: kasan/kbuild: fix missing flags on first build

[Conor Dooley]

> > AFAICT. Then later on it'd become more like:
> >
> > config HAVE_CFI_ICALL_NORMALIZE_INTEGERS_RUSTC
> >         def_bool y
> >         depends on HAVE_CFI_ICALL_NORMALIZE_INTEGERS_CLANG
> >         depends on RISCV || ((ARM64 || x86_64) && RUSTC_VERSION >= 107900)
> >         depends on (ARM64 || x86_64) || (RISCV && RUSTC_VERSION >= 999999)
> >         # With GCOV/KASAN we need this fix: https://github.com/rust-lang/rust/pull/129373
> >         depends on (RUSTC_LLVM_VERSION >= 190103 && RUSTC_VERSION >= 108200) || \
> >                 (!GCOV_KERNEL && !KASAN_GENERIC && !KASAN_SW_TAGS)
> >
> > but that exact sort of mess is what becomes unwieldy fast since that
> > doesn't even cover 32-bit arm.
> 
> I think a better way of writing it is like this:
> 
> depends on ARCH1 || ARCH2 || ARCH3
> depends on !ARCH1 || RUSTC_VERSION >= 000000
> depends on !ARCH2 || RUSTC_VERSION >= 000000
> depends on !ARCH3 || RUSTC_VERSION >= 000000


Ye, that's a lot more manageable than what I came up with, shoulda
really done better since the option I used for a reference looks a lot
more like this than what I had... Thanks.

Attachment: signature.asc
Description: PGP signature