Re: [PATCH v5] dt-bindings: mfd: twl: Add missing sub-nodes for TWL4030 & TWL603x

[Andreas Kemnade]

Am Tue,  2 Sep 2025 23:29:21 +0200
schrieb Jihed Chaibi <jihed.chaibi.dev@xxxxxxxxx>:

[...]
> +      be paired with a generic fallback (generally for power
saving mode).
> +    additionalProperties: false
> +    properties:
> +      compatible:
> +        oneOf:
> +          - enum:
> +              - ti,twl4030-power
> +              - ti,twl4030-power-reset
> +              - ti,twl4030-power-idle
> +              - ti,twl4030-power-idle-osc-off
> +              # Add all board-specific compatibles for completeness
> +              - ti,twl4030-power-omap3-sdp
> +              - ti,twl4030-power-omap3-ldp
> +              - ti,twl4030-power-omap3-evm
> +              - ti,twl4030-power-beagleboard-xm
> +              - ti,twl4030-power-n900
> +          - items:
> +              - enum:
> +                  - ti,twl4030-power
> +                  - ti,twl4030-power-reset
> +                  - ti,twl4030-power-idle
> +                  - ti,twl4030-power-idle-osc-off
> +                  # Add all board-specific compatibles for completeness
> +                  - ti,twl4030-power-omap3-sdp
> +                  - ti,twl4030-power-omap3-ldp
> +                  - ti,twl4030-power-omap3-evm
> +                  - ti,twl4030-power-beagleboard-xm
> +                  - ti,twl4030-power-n900
> +              - enum:
> +                  # Fallback (for power saving mode)
> +                  - ti,twl4030-power-idle
> +                  - ti,twl4030-power-idle-osc-off

this allows quite weird combinations like
 "ti,twl4030-power-idle", "ti,twl4030-power-idle".
I would propose to rather clean this up to things used in
twl4030-power.c and at the same time available in dts, also
taking the brush in the dts. I do not expect that these specific
compatibles are in use anywhere. I looked around earlier.

Regards,
Andreas