Re: [PATCH v2 1/4] dt-bindings: iio: adc: ad7768-1: add new supported parts

[Jonathan Santos]

On 08/31, Krzysztof Kozlowski wrote:
> On 31/08/2025 05:43, Jonathan Santos wrote:
> >>>      maxItems: 1
> >>> @@ -58,6 +66,18 @@ properties:
> >>>      description:
> >>>        ADC reference voltage supply
> >>>  
> >>> +  adi,gain-milli:
> >>> +    description: |
> >>> +       Specifies the gain applied by the Analog Anti-Aliasing Filter (AAF) to the
> >>> +       ADC input (in milli units). The hardware gain is determined by which input
> >>
> >>
> >> I don't think there is no such thing as "milli units". milli is SI
> >> prefix, not unit. So "units" is the unit? Or how exactly?
> >>
> >> Basis points were before since 2022 so I don't get why these other
> >> bindings introduced in 2024 could not use it?
> >>
> >> Anyway, if you ever do not apply reviewers comment, then your commit msg
> >> should explain this. Otherwise you get the same discussion here.
> >>
> > 
> > Yes, you are right. We shouldn't use milli as suffix. However, may I
> > suggest another option?
> > 
> > I believe -permille is more appropriate because it represents a 1/1000
> > proportion, which gives the precision we need to cover all values.
> > 
> > so it would be something like: adi,aaf-gain-permille
> > 
> > Is that ok for you?
> > 
> > Thanks for the feedback,
> > Jonathan S.
> 
> 
> What's wrong with existing unit I pointed out before?
>

Nothing wrong, just thought permille would be a clearer unit than basis
point for the user. But i can proceed with bp, no problem.

> BTW, any idea why your reply-to header is completely corrupted (copies
> in-reply-to...)?
>

Yes, i was including the in-reply- to, sorry about that.

> 
> Best regards,
> Krzysztof