Re: [PATCH 1/4] dt-bindings: reset: thead,th1520-reset: Add controllers for more subsys

[Yao Zi]

On Tue, Sep 02, 2025 at 03:57:07PM +0200, Philipp Zabel wrote:
> On Mo, 2025-09-01 at 04:23 +0000, Yao Zi wrote:
> > TH1520 SoC is divided into several subsystems, most of them have
> > distinct reset controllers. Let's document reset controllers other than
> > the one for VO subsystem and IDs for their reset signals.
> > 
> > Signed-off-by: Yao Zi <ziyao@xxxxxxxxxxx>
> > ---
> >  .../bindings/reset/thead,th1520-reset.yaml    |   8 +-
> >  .../dt-bindings/reset/thead,th1520-reset.h    | 219 +++++++++++++++++-
> >  2 files changed, 223 insertions(+), 4 deletions(-)
> > 
> [...]
> > diff --git a/include/dt-bindings/reset/thead,th1520-reset.h b/include/dt-bindings/reset/thead,th1520-reset.h
> > index ee799286c175..927e251edfab 100644
> > --- a/include/dt-bindings/reset/thead,th1520-reset.h
> > +++ b/include/dt-bindings/reset/thead,th1520-reset.h
> > @@ -7,11 +7,186 @@
> [...]
> > +/* AP Subsystem */
> [...]
> > +#define TH1520_RESET_ID_C910_C0			5
> > +#define TH1520_RESET_ID_C910_C1			5
> > +#define TH1520_RESET_ID_C910_C2			5
> > +#define TH1520_RESET_ID_C910_C3			5
> 
> As the kernel test robot already noticed, this doesn't seem right.

Yes, this is a copy-paste error. I'll fix it and run static check before
sending v2. Thanks.

> regards
> Philipp

Best regards,
Yao Zi