Re: [PATCH v8 5/9] arm64: dts: qcom: qcs6490-audioreach: Modify LPASS macros clock settings for audioreach

[Prasad Kumpatla]

On 9/2/2025 8:17 PM, Bjorn Andersson wrote:
> On Thu, Aug 21, 2025 at 10:19:10AM +0530, Prasad Kumpatla wrote:
> > From: Mohammad Rafi Shaik <mohammad.rafi.shaik@xxxxxxxxxxxxxxxx>
> >
> > Modify and enable WSA, VA, RX and TX lpass macros and lpass_tlmm clock
> > settings. For audioreach solution mclk, npl and fsgen clocks are enabled
> > through the q6prm clock driver.
> >
> > For qcs6490 RX drives clk from TX CORE which is mandated from DSP side,
> > Unlike dedicated core clocks. Core TX clk is used for both RX and
> > WSA as per DSP recommendations.
>
> This differs from all other platforms, so please make sure the commit
> message explains why.
>
> As with patch 1, is this specific to qcs6490?

Sure, will update the commit text as per your recommendations.

Thanks,
Prasad

> Regards,
> Bjorn
>
> > Signed-off-by: Mohammad Rafi Shaik <mohammad.rafi.shaik@xxxxxxxxxxxxxxxx>
> > Co-developed-by: Prasad Kumpatla <quic_pkumpatl@xxxxxxxxxxx>
> > Signed-off-by: Prasad Kumpatla <quic_pkumpatl@xxxxxxxxxxx>
> > Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>
> > ---
> >   .../boot/dts/qcom/qcs6490-audioreach.dtsi     | 61 +++++++++++++++++++
> >   1 file changed, 61 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/qcs6490-audioreach.dtsi b/arch/arm64/boot/dts/qcom/qcs6490-audioreach.dtsi
> > index 282938c042f7..6d3a9e171066 100644
> > --- a/arch/arm64/boot/dts/qcom/qcs6490-audioreach.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/qcs6490-audioreach.dtsi
> > @@ -12,6 +12,67 @@
> >   #include <dt-bindings/sound/qcom,q6afe.h>
> >   #include <dt-bindings/sound/qcom,q6dsp-lpass-ports.h>
> >   
> > +&lpass_rx_macro {
> > +	/delete-property/ power-domains;
> > +	/delete-property/ power-domain-names;
> > +	clocks = <&q6prmcc LPASS_CLK_ID_TX_CORE_MCLK LPASS_CLK_ATTRIBUTE_COUPLE_NO>,
> > +		 <&q6prmcc LPASS_CLK_ID_TX_CORE_NPL_MCLK  LPASS_CLK_ATTRIBUTE_COUPLE_NO>,
> > +		 <&q6prmcc LPASS_HW_MACRO_VOTE LPASS_CLK_ATTRIBUTE_COUPLE_NO>,
> > +		 <&q6prmcc LPASS_HW_DCODEC_VOTE LPASS_CLK_ATTRIBUTE_COUPLE_NO>,
> > +		 <&lpass_va_macro>;
> > +	clock-names = "mclk",
> > +		      "npl",
> > +		      "macro",
> > +		      "dcodec",
> > +		      "fsgen";
> > +};
> > +
> > +&lpass_tlmm {
> > +	clocks = <&q6prmcc LPASS_HW_MACRO_VOTE LPASS_CLK_ATTRIBUTE_COUPLE_NO>,
> > +		 <&q6prmcc LPASS_HW_DCODEC_VOTE LPASS_CLK_ATTRIBUTE_COUPLE_NO>;
> > +	clock-names = "core",
> > +		      "audio";
> > +};
> > +
> > +&lpass_tx_macro {
> > +	/delete-property/ power-domains;
> > +	/delete-property/ power-domain-names;
> > +	clocks = <&q6prmcc LPASS_CLK_ID_TX_CORE_MCLK LPASS_CLK_ATTRIBUTE_COUPLE_NO>,
> > +		 <&q6prmcc LPASS_CLK_ID_TX_CORE_NPL_MCLK  LPASS_CLK_ATTRIBUTE_COUPLE_NO>,
> > +		 <&q6prmcc LPASS_HW_MACRO_VOTE LPASS_CLK_ATTRIBUTE_COUPLE_NO>,
> > +		 <&q6prmcc LPASS_HW_DCODEC_VOTE LPASS_CLK_ATTRIBUTE_COUPLE_NO>,
> > +		 <&lpass_va_macro>;
> > +	clock-names = "mclk",
> > +		      "npl",
> > +		      "macro",
> > +		      "dcodec",
> > +		      "fsgen";
> > +};
> > +
> > +&lpass_va_macro {
> > +	/delete-property/ power-domains;
> > +	/delete-property/ power-domain-names;
> > +	clocks = <&q6prmcc LPASS_CLK_ID_VA_CORE_MCLK LPASS_CLK_ATTRIBUTE_COUPLE_NO>,
> > +		 <&q6prmcc LPASS_HW_MACRO_VOTE LPASS_CLK_ATTRIBUTE_COUPLE_NO>,
> > +		 <&q6prmcc LPASS_HW_DCODEC_VOTE LPASS_CLK_ATTRIBUTE_COUPLE_NO>;
> > +	clock-names = "mclk",
> > +		      "macro",
> > +		      "dcodec";
> > +};
> > +
> > +&lpass_wsa_macro {
> > +	clocks = <&q6prmcc LPASS_CLK_ID_TX_CORE_MCLK LPASS_CLK_ATTRIBUTE_COUPLE_NO>,
> > +		 <&q6prmcc LPASS_CLK_ID_TX_CORE_NPL_MCLK LPASS_CLK_ATTRIBUTE_COUPLE_NO>,
> > +		 <&q6prmcc LPASS_HW_MACRO_VOTE LPASS_CLK_ATTRIBUTE_COUPLE_NO>,
> > +		 <&q6prmcc LPASS_HW_DCODEC_VOTE LPASS_CLK_ATTRIBUTE_COUPLE_NO>,
> > +		 <&lpass_va_macro>;
> > +	clock-names = "mclk",
> > +		      "npl",
> > +		      "macro",
> > +		      "dcodec",
> > +		      "fsgen";
> > +};
> > +
> >   &remoteproc_adsp_glink {
> >   	/delete-node/ apr;
> >   
> > --
> > 2.34.1