Re: [PATCH v8 5/7] arm64: dts: qcom: Add initial support for MSM8937

[Barnabás Czémán]

On 3 September 2025 12:42:38 CEST, Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx> wrote:
>On 8/31/25 2:29 PM, Barnabás Czémán wrote:
>> From: Dang Huynh <danct12@xxxxxxxxxx>
>> 
>> Add initial support for MSM8937 SoC.
>> 
>> Signed-off-by: Dang Huynh <danct12@xxxxxxxxxx>
>> Co-developed-by: Barnabás Czémán <barnabas.czeman@xxxxxxxxxxxxxx>
>> Signed-off-by: Barnabás Czémán <barnabas.czeman@xxxxxxxxxxxxxx>
>> ---
>
>[...]
>
>> +		qfprom: qfprom@a4000 {
>> +			compatible = "qcom,msm8937-qfprom", "qcom,qfprom";
>> +			reg = <0x000a4000 0x1000>;
>
>here you reserve 0x1000 for the qfprom
>
>[...]
>
>> +			gpu_speed_bin: gpu-speed-bin@601b {
>> +				reg = <0x601b 0x1>;
>
>and here you make way for OOB accesses
Ack
>
>Make qfprom length 0x3000 with the current base and the gpu
>speed bin should be at base+0x201b, I *think* (the docs aren't
>super clear on that)
>
>[...]
>
>> +		mdss: display-subsystem@1a00000 {
>> +			compatible = "qcom,mdss";
>> +			reg = <0x01a00000 0x1000>,
>> +			      <0x01ab0000 0x1040>;
>
>In v5, I pointed out the size of vbif should be 0x3000.. and the random
Where 0x3000 is come from downstream is using 0x1040 for vbif.
>newline below wcss-wlan2-pins {} is still there too
>
>Konrad