Re: [PATCH v2] pinctrl: eswin: Fix regulator error check and Kconfig dependency

[Linus Walleij]

On Wed, Sep 3, 2025 at 11:19 AM Yulin Lu <luyulin@xxxxxxxxxxxxxxxxxx> wrote:

> Smatch reported the following warning in eic7700_pinctrl_probe():
>
>   drivers/pinctrl/pinctrl-eic7700.c:638 eic7700_pinctrl_probe()
>   warn: passing zero to 'PTR_ERR'
>
> The root cause is that devm_regulator_get() may return NULL when
> CONFIG_REGULATOR is disabled. In such case, IS_ERR_OR_NULL() triggers
> PTR_ERR(NULL) which evaluates to 0, leading to passing a success code
> as an error.
>
> However, this driver cannot work without a regulator. To fix this:
>
>  - Change the check from IS_ERR_OR_NULL() to IS_ERR()
>  - Update Kconfig to explicitly select REGULATOR and
>    REGULATOR_FIXED_VOLTAGE, ensuring that the regulator framework is
>    always available.
>
> This resolves the Smatch warning and enforces the correct dependency.
>
> Suggested-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> Fixes: 5b797bcc00ef ("pinctrl: eswin: Add EIC7700 pinctrl driver")
> Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> Closes: https://lore.kernel.org/linux-gpio/aKRGiZ-fai0bv0tG@stanley.mountain/
> Signed-off-by: Yulin Lu <luyulin@xxxxxxxxxxxxxxxxxx>

Patch applied!

Yours,
Linus Walleij