Re: [PATCH v5 14/27] clk: mediatek: Add MT8196 peripheral clock support

[AngeloGioacchino Del Regno]

Il 05/09/25 07:05, Chen-Yu Tsai ha scritto:
> On Fri, Aug 29, 2025 at 5:21 PM Laura Nao <laura.nao@xxxxxxxxxxxxx> wrote:
> > Add support for the MT8196 peripheral clock controller, which provides
> > clock gate control for dma/flashif/msdc/pwm/spi/uart.
> >
> > Signed-off-by: Laura Nao <laura.nao@xxxxxxxxxxxxx>
>
> Not sure why CLK_OPS_PARENT_ENABLE was removed, but it does seem like the
> right thing to do, since this block is always on and doesn't require a
> clock to be enabled before accessing the registers.
>
> Reviewed-by: Chen-Yu Tsai <wenst@xxxxxxxxxxxx> # CLK_OPS_PARENT_ENABLE change
>
> Note that I did not go through the bit definitions. I assume the other
> Collabora folks did a good job of reviewing those.

Yes, I did :-)

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>

Cheers,
Angelo