Re: [PATCH 3/5] drm/solomon: Simplify mode_valid() using DRM helper

From: Javier Martinez Canillas
Date: Wed Sep 17 2025 - 05:27:44 EST


Iker Pedrosa <ikerpedrosam@xxxxxxxxx> writes:

> The ssd130x_crtc_mode_valid() function contains a manual implementation
> to validate the display mode against the panel's single fixed resolution.
>
> This pattern is common for simple displays, and the DRM core already
> provides the drm_crtc_helper_mode_valid_fixed() helper for this exact
> use case.
>
> Signed-off-by: Iker Pedrosa <ikerpedrosam@xxxxxxxxx>
> ---

Indeed.

Reviewed-by: Javier Martinez Canillas <javierm@xxxxxxxxxx>

--
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat