Re: [PATCH v1 1/2] perf test: Add an 'import perf' test shell script

[Collin Funk]

Ian Rogers <irogers@xxxxxxxxxx> wrote:

> The 'import perf' test needs to set up a path to the python module as
> well as to know the python command to invoke. These are hard coded at
> build time to be build a directory and the python used in the build,
> which is less than desirable. Avoid the hard coded values by reusing
> the existing shell script python setup and determine a potential built
> python module via the path of the perf executable.
> 
> Signed-off-by: Ian Rogers <irogers@xxxxxxxxxx>
> ---
>  tools/perf/tests/shell/python-use.sh | 36 ++++++++++++++++++++++++++++
>  1 file changed, 36 insertions(+)
>  create mode 100755 tools/perf/tests/shell/python-use.sh

Aside from avoiding hard coded build directories, this also looks much cleaner to me.

Reviewed-by Collin Funk <collin.funk1@xxxxxxxxx>

Collin