Re: [PATCH] PCI: ixp4xx: Guard ARM32-specific hook_fault_code()

[Russell King (Oracle)]

On Tue, Sep 30, 2025 at 08:59:36PM +0200, Linus Walleij wrote:
> On Thu, Sep 25, 2025 at 10:27 PM Bjorn Helgaas <helgaas@xxxxxxxxxx> wrote:
> 
> > From: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>
> >
> > hook_fault_code() is an ARM32-specific API.  Guard it and related code with
> > CONFIG_ARM #ifdefs so the driver can be compile tested on other
> > architectures.
> >
> > Signed-off-by: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>
> 
> It looks OK to me
> Acked-by: Linus Walleij <linus.walleij@xxxxxxxxx>
> 
> I see some other ARM32 drivers use it too, but we surely do
> not have a arch-agnostic way of handling bus errors so perhaps it
> need to be like this.
> 
> I think Russell created the fault hooks originally so CC:ing him
> in.

I wonder what the point of compile testing if it needs code to be
#ifdef'd out.

Wouldn't it be better to add something like:

#ifndef CONFIG_ARM
static inline void hook_fault_code(int n, int (*fn)(unsigned long, unsigned int,
						    struct pt_regs *),
				   int sig, int code, const char *name)
{
}
#endif

maybe to a local header that pci-imx6, pci-keystone, pcie-rcar-host
and pci-ixp4xx can all share?

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!