Re: [PATCH v2 1/3] mtd: spi-nor: macronix: Drop the redundant flash info fields

[Cheng Ming Lin]

Hi Michael,

Michael Walle <mwalle@xxxxxxxxxx> 於 2025年9月24日 週三 下午8:11寫道：
>
> > The root cause of this problem lies in the failure of parsing the SFDP
> > data for the flash, rather than an issue with the patch itself. I believe
> > we should not revert this patch.
>
> I disagree. There are Macronix flashes with that ID which doesn't
> have SFDP.  And this patch is dropping support for them. See also
> [1]. Now I'm not sure it is worth reverting this commit. Nobody,
> except Guenter complained, but only *so far* (and that patch is in
> since 6.16). Any opinions?

I agree with reverting this patch. When I initially verified it, the
devices I had on hand all supported SFDP, so I did not catch this issue.
After checking again, I confirm that some older flashes without SFDP are
indeed affected.

Would it make sense to only change the `.name` field to use a comment,
while keeping the rest as is? That way we can still support flashes that
may not provide SFDP.

>
> -michael
>
> [1] https://lore.kernel.org/r/DD10GE4EOCD7.CPTN7198QFUV@xxxxxxxxxx/

Thanks,
Cheng Ming Lin