RE: [PATCH rtw-next v2] wifi: rtw89: Replace hardcoded strings with helper functions

[Ping-Ke Shih]

Yu-Chun Lin <eleanor15x@xxxxxxxxx> wrote:
> Replace hardcoded strings with 'str_on_off()', 'str_enable_disable()',
> and 'str_read_write()'.
> 
> The change improves readability.
> 
> Signed-off-by: Yu-Chun Lin <eleanor15x@xxxxxxxxx>

Acked-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx>


> diff --git a/drivers/net/wireless/realtek/rtw89/wow.c b/drivers/net/wireless/realtek/rtw89/wow.c
> index 5faa51ad896a..6950fed96267 100644
> --- a/drivers/net/wireless/realtek/rtw89/wow.c
> +++ b/drivers/net/wireless/realtek/rtw89/wow.c
> @@ -1,6 +1,7 @@
>  // SPDX-License-Identifier: GPL-2.0 OR BSD-3-Clause
>  /* Copyright(c) 2019-2022  Realtek Corporation
>   */
> +

No need to add this blink line. I'll remove this when merging patch. 
(Sending v3 is also fine to me)

>  #include "cam.h"
>  #include "core.h"
>  #include "debug.h"
> @@ -1248,7 +1249,7 @@ static int rtw89_wow_check_fw_status(struct rtw89_dev *rtwdev, bool wow_enable)
>                                        mac->wow_ctrl.addr, mac->wow_ctrl.mask);
>         if (ret)
>                 rtw89_err(rtwdev, "failed to check wow status %s\n",
> -                         wow_enable ? "enabled" : "disabled");
> +                         str_enabled_disabled(wow_enable));
>         return ret;
>  }
> 
> --
> 2.34.1