Re: [PATCH] usb: dwc3: Don't call clk_bulk_disable_unprepare() twice

From: Thinh Nguyen

Date: Mon Sep 29 2025 - 19:46:31 EST


On Mon, Sep 29, 2025, Thinh Nguyen wrote:
> On Mon, Sep 29, 2025, Christophe JAILLET wrote:
> > devm_clk_bulk_get_all_enabled() is used in the probe, so
> > clk_bulk_disable_unprepare() should not be called explicitly in the remove
> > function.
>
> Why not? The clk_bulk_disable_unprepare() is to disable and unprepare
> the clocks, not freeing the clocks.
>

gah.. I wrote this too quickly without checking...

It does unwind on remove. This is fine.

Acked-by: Thinh Nguyen <Thinh.Nguyen@xxxxxxxxxxxx>

BR,
Thinh