Re: [PATCH v1] scsi: ufs: core: Introduce quirk to check UTP error

From: Bart Van Assche

Date: Mon Sep 29 2025 - 12:49:22 EST


On 9/29/25 3:58 AM, HOYOUNG SEO wrote:
+ /*
+ * This quirk indicated that report the error when UTP error occurs.
+ * Enable this quirk will the error handler allows the ufs to be reocvery.
+ */
+ UFSHCD_QUIRK_UTP_ERROR = 1 << 26,

Quirks should only be introduced for behavior that differs between host
controllers. I don't see why the behavior introduced by this patch
should only be enabled for some UFS host controllers and not for all UFS
host controllers. Please remove "UFSHCD_QUIRK_UTP_ERROR" from this patch
such that UTP errors trigger UFS error handling for all UFS host
controllers.

Thanks,

Bart.