Re: [PATCH 1/2] dt-bindings: gpio: Add Tegra410 support
From: Bartosz Golaszewski
Date: Mon Sep 29 2025 - 09:41:22 EST
On Mon, Sep 29, 2025 at 9:24 AM Kartik Rajput <kkartik@xxxxxxxxxx> wrote:
>
> Hi Conor,
>
> Thanks for reviewing the patch!
>
> On 19/09/25 22:44, Conor Dooley wrote:
> > On Fri, Sep 19, 2025 at 03:06:26PM +0530, Kartik Rajput wrote:
> >> From: Prathamesh Shete <pshete@xxxxxxxxxx>
> >>
> >> Add the port definitions for the main GPIO controller found on
> >> Tegra410.
> >>
> >> Signed-off-by: Prathamesh Shete <pshete@xxxxxxxxxx>
> >> Signed-off-by: Kartik Rajput <kkartik@xxxxxxxxxx>
> >> ---
> >
> > Why are you modifying a binding header for devicetree when the driver
> > only appear to grow acpi support?
> >
>
> Although Tegra410 is ACPI-only and does not require a new compatible string,
> we chose to add the GPIO port definitions to the DT binding header to stay
> consistent with previous Tegra SoCs.
>
> Thanks,
> Kartik
>
Hi!
The kernel policy is not to add symbols nobody is using. Please drop them.
Bartosz