Re: [PATCH 2/2] arm64: dts: rockchip: Add devicetree for the FriendlyElec NanoPi R76S

[Dragan Simic]

On 2025-09-27 15:52, Tianling Shen wrote:
> On 2025/9/27 21:47, Dragan Simic wrote:
> > On 2025-09-27 09:37, Diederik de Haas wrote:
> > > On Sat Sep 27, 2025 at 3:19 AM CEST, Tianling Shen wrote:
> > > > On 2025/9/27 0:07, Diederik de Haas wrote:
> > > > > It is recommended to use the labels in the schematics to define the
> > > > > pinctl nodes (and thus their references). In quite a lot of cases 
> > > > > that's
> > > > > indeed the case, but not for gpio-keys (USER_BUT) or these 
> > > > > gpio-leds
> > > > > pinctls.
> > > >
> > > > I cannot find any specific naming rules from the gpio-keys[1] and
> > > > gpio-leds[2] bindings, did I miss any update?
> > > >
> > > > I think this naming matches the current practice at least in 
> > > > rockchip's
> > > > dt tree.
> > >
> > > There is an unofficial rule/aim:
> > > https://lore.kernel.org/linux-rockchip/5360173.ktpJ11cQ8Q@diego/
> > > But granted, there is 'some' inconsistency.
> > >
> > > And used in f.e.
> > > https://lore.kernel.org/linux-rockchip/20250727144409.327740-4- 
> > > jonas@xxxxxxxxx/
> > >
> > > Where you can just copy the pinctrl labels from the dts[i] and paste
> > > that in the schematic document and you're instantly at the right 
> > > place.
> > > Which is the exact purpose of that rule/aim.
> >
> > Is the schematic actually publicly available?  I tried searching for
> > it, but found nothing, unfortunately.
>
> The schematic for NanoPi R76S is available at
> https://wiki.friendlyelec.com/wiki/images/6/60/NanoPi_R76S_LP4X_2411_SCH.pdf
>
> For more information please move to
> https://wiki.friendlyelec.com/wiki/index.php/NanoPi_R76S.

Oh, I see.  I'm sorry, somehow I got the NanoPi R76S mixed up with
another board whose DT has also been submitted recently, [1] for
which I was unable to find the schematic.  I already found the R76S
schematic, which was actually really easy to do.

By the way, it would be good to provide a link to the schematic as
a reference in the description of patch 2/2, if there turns out to
be v3 of this series.

[1] 
https://lore.kernel.org/linux-rockchip/20250925-print-defog-992c12970b37@spud/T/#t