Re: [PATCH v8 mm-new 04/12] mm: thp: add support for BPF based THP order selection

[Randy Dunlap]

On 9/26/25 8:13 AM, Usama Arif wrote:
> > +config BPF_THP_GET_ORDER_EXPERIMENTAL
> > +	bool "BPF-based THP order selection (EXPERIMENTAL)"
> > +	depends on TRANSPARENT_HUGEPAGE && BPF_SYSCALL
> > +
> > +	help
> > +	  Enable dynamic THP order selection using BPF programs. This
> > +	  experimental feature allows custom BPF logic to determine optimal
> > +	  transparent hugepage allocation sizes at runtime.
> > +
> > +	  WARNING: This feature is unstable and may change in future kernel
> > +	  versions.
> > +
> I am assuming this series opens up the possibility of additional hooks being added in
> the future. Instead of naming this BPF_THP_GET_ORDER_EXPERIMENTAL, should we
> name it BPF_THP? Otherwise we will end up with 1 Kconfig option per hook, which
> is quite bad.
>
> Also It would be really nice if we dont put "EXPERIMENTAL" in the name of the defconfig.
> If its decided that its not experimental anymore without any change to the code needed,
> renaming the defconfig will break it for everyone.

s/defconfig/Kconfig symbol/

Otherwise agreed.
Thanks.
--
~Randy