Re: [PATCH] ntfs3: fix uninit memory after failed mi_read in mi_format_new

From: David Hunter

Date: Sun Sep 28 2025 - 11:25:16 EST


On 9/25/25 16:36, Raphael Pinsonneault-Thibeault wrote:

> - } else if (mi_read(mi, is_mft)) {
> - ;
> - } else if (rec->rhdr.sign == NTFS_FILE_SIGNATURE) {
> - /* Record is reused. Update its sequence number. */
> - seq = le16_to_cpu(rec->seq) + 1;
> - if (!seq)
> - seq = 1;
> + } else {
> + err = mi_read(mi, is_mft);
> + if (err) {
> + return err;
> + }
> +
> + if (rec->rhdr.sign == NTFS_FILE_SIGNATURE) {
> + /* Record is reused. Update its sequence number. */
> + seq = le16_to_cpu(rec->seq) + 1;
> + if (!seq)
> + seq = 1;
> + }

How was this tested?