Re: [PATCH v5 7/8] man/man2/open_tree{,_attr}.2: document new open_tree_attr() API

[Alejandro Colomar]

Hi Askar,

On Wed, Oct 01, 2025 at 03:38:41AM +0300, Askar Safin wrote:
> Aleksa Sarai <cyphar@xxxxxxxxxx>:
> > +mntfd2 = open_tree(mntfd1, "", OPEN_TREE_CLONE,
> > +                   &attr, sizeof(attr));
> 
> Your whole so-called "open_tree_attr example" doesn't contain any open_tree_attr
> calls. :)
> 
> I think you meant open_tree_attr here.

I'll wait for Aleksa to confirm before applying and amending.

> > +\&
> > +/* Create a new copy with the id-mapping cleared */
> > +memset(&attr, 0, sizeof(attr));
> > +attr.attr_clr = MOUNT_ATTR_IDMAP;
> > +mntfd3 = open_tree(mntfd1, "", OPEN_TREE_CLONE,
> > +                   &attr, sizeof(attr));
> 
> And here.
> 
> Otherwise your whole patchset looks good. Add to whole patchset:
> Reviewed-by: Askar Safin <safinaskar@xxxxxxxxx>

Thanks!  I'll retro-fit that to the commits I've aplied already too, as
I haven't pushed them to master yet.


Have a lovely day!
Alex

-- 
<https://www.alejandro-colomar.es>
Use port 80 (that is, <...:80/>).

Attachment: signature.asc
Description: PGP signature