Re: [PATCH v2 2/3] alpha: don't reference obsolete termio struct for TC* constants

[Sam James]

Magnus Lindholm <linmag7@xxxxxxxxx> writes:

>> +#define TCGETA          0x5405
>> +#define TCSETA          0x5406
>> +#define TCSETAW         0x5407
>> +#define TCSETAF         0x5408
>
> Hi,
>
> A similar patch aimed for powerpc (commit ab10727) had the following
> definitions:
>
> #define TCGETA    0x40147417
> #define TCSETA    0x80147418
> #define TCSETAW 0x80147419
> #define TCSETAF  0x8014741c
>
> On Alpha, if I do something like printf("TCGETA = 0x%08x\n", TCGETA);
> I get TCGETA = 0x40127417, but on an intel/x64 I get 0x5405.
> Is this something we need to consider here?

There are fallback definitions in generic:

tools/include/uapi/asm-generic/ioctls.h:24:#define TCGETA               0x5405
include/uapi/asm-generic/ioctls.h:24:#define TCGETA             0x5405

I think those are used where there was no historical value (i.e. for
newer ioctls). Coud you run something like
https://bugs.gentoo.org/962600#c5 to get the full list of (removed)
constant values for alpha? It's awkward for me to test with older glibc.

>
> Regards
>
> Magnus

thanks,
sam