Re: [PATCH v3 10/11] arm64: dts: qcom: sdm845-lg-judyln: Add lab/ibb

From: Paul Sajna
Date: Thu Oct 02 2025 - 00:56:03 EST


October 1, 2025 at 9:09 AM, "Konrad Dybcio" <konrad.dybcio@xxxxxxxxxxxxxxxx mailto:konrad.dybcio@xxxxxxxxxxxxxxxx?to=%22Konrad%20Dybcio%22%20%3Ckonrad.dybcio%40oss.qualcomm.com%3E > wrote:


>
> On 9/29/25 7:05 AM, Paul Sajna wrote:
>
> >
> > These regulators seemingly help the lcd to work better
> >
> Electronics generally work better when the required power supplies
> are enabled..
>
> >
> > Signed-off-by: Paul Sajna <sajattack@xxxxxxxxxxxxxxxx>
> > ---
> > arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts | 17 +++++++++++++++++
> > 1 file changed, 17 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts b/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
> > index 3106fdc9b679bc6a43a1a490c61b73a63003f7e1..9c3662a3d93e124667474753e0f11d0e98698aa0 100644
> > --- a/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
> > +++ b/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
> > @@ -48,10 +48,27 @@ zap-shader {
> > };
> > };
> >
> > +&ibb {
> > + regulator-min-microvolt = <4600000>;
> > + regulator-max-microvolt = <6000000>;
> > + regulator-over-current-protection;
> > + regulator-pull-down;
> > + regulator-soft-start;
> > + qcom,discharge-resistor-kohms = <300>;
> > +};
> > +
> > &ipa {
> > firmware-name = "qcom/sdm845/lg/judyln/ipa_fws.mbn";
> > };
> >
> > +&lab {
> > + regulator-min-microvolt = <4600000>;
> > + regulator-max-microvolt = <6000000>;
> > + regulator-over-current-protection;
> > + regulator-pull-down;
> > + regulator-soft-start;
> > +};
> >
> This patch will allow any values between 4.6 V and 6.0 V to
> be set on your phone, with the kernel defaulting to 4.6 V at
> boot and staying there until (if?) any driver requests that to
> change.
>
> Your panel probably expects a *very* specific pair of voltages
> and any deviation may cause unpredictable consequences, including
> magic smoke if you happen to go over a certain limit.
>
> You should most likely hardcode that specific expected voltage here
>
> Konrad
>

These are the values used in downstream android dts
https://github.com/LineageOS/android_kernel_lge_sdm845/blob/efa8458f79dffeb380d43b38b9403407f87d9f05/arch/arm64/boot/dts/qcom/pmi8998.dtsi#L484-L485