Re: [PATCH v2 2/2] drm/panthor: skip regulator setup if no such prop
From: Steven Price
Date: Thu Oct 02 2025 - 04:44:25 EST
On 28/09/2025 10:03, Rain Yang wrote:
> From: Rain Yang <jiyu.yang@xxxxxxx>
>
> The regulator is optional, skip the setup instead of returning an
> error if it is not present
>
> Signed-off-by: Rain Yang <jiyu.yang@xxxxxxx>
Reviewed-by: Steven Price <steven.price@xxxxxxx>
> ---
> drivers/gpu/drm/panthor/panthor_devfreq.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/panthor/panthor_devfreq.c b/drivers/gpu/drm/panthor/panthor_devfreq.c
> index 3686515d368d..2df1d76d84a0 100644
> --- a/drivers/gpu/drm/panthor/panthor_devfreq.c
> +++ b/drivers/gpu/drm/panthor/panthor_devfreq.c
> @@ -146,10 +146,9 @@ int panthor_devfreq_init(struct panthor_device *ptdev)
> ptdev->devfreq = pdevfreq;
>
> ret = devm_pm_opp_set_regulators(dev, reg_names);
> - if (ret) {
> + if (ret && ret != -ENODEV) {
> if (ret != -EPROBE_DEFER)
> DRM_DEV_ERROR(dev, "Couldn't set OPP regulators\n");
> -
> return ret;
> }
>