Re: [PATCH v3] drm/komeda: Convert logging in komeda_crtc.c to drm_* with drm_device parameter
From: Shuah Khan
Date: Tue Oct 07 2025 - 19:16:29 EST
On 10/3/25 11:51, Rahul Kumar wrote:
Hi Liviu,
Just following up to ask if anything more is needed from my side for
this patch, or if you plan to pick it up in this merge window.
Thanks,
Rahul
Rahul, no top posting. Please give people time to respond before
sending a second email asking for feedback. I see two messages
back to back from you - perhaps an error during send.
On Fri, Sep 26, 2025 at 3:00 PM Rahul Kumar <rk0006818@xxxxxxxxx> wrote:
Replace all dev_err(), dev_warn(), dev_info() and DRM_ERROR/WARN/INFO()
calls in drivers/gpu/drm/arm/display/komeda/komeda_crtc.c with the
corresponding drm_err(), drm_warn(), and drm_info() helpers.
The new drm_*() logging functions take a struct drm_device * as the
first argument. This allows the DRM core to prefix log messages with
the specific DRM device name and instance, which is essential for
distinguishing logs when multiple GPUs or display controllers are present.
This change aligns komeda with the DRM TODO item: "Convert logging to
drm_* functions with drm_device parameter".
Signed-off-by: Rahul Kumar <rk0006818@xxxxxxxxx>
Reviewed-by: Liviu Dudau <liviu.dudau@xxxxxxx>
---
Changes since v2:
- Added Reviewed-by tag from Liviu Dudau
thanks,
-- Shuah