Re: [PATCH 16/16] media: rockchip: rga: add rga3 support

[Sven Püschel]

Hi Krzysztof,

On 10/7/25 10:39 AM, Krzysztof Kozlowski wrote:
> On 07/10/2025 17:32, Sven Püschel wrote:
> > Add support for the RGA3 unit contained in the RK3588.
> >
> > Only a basic feature set consisting of scaling and color conversion is
> > implemented. Advanced features like rotation and cropping will just be
> > ignored. Also the BT601F color space conversion is currently hard coded.
> >
> > The register address defines were copied from the
> > vendor Rockchip kernel sources and slightly adjusted to not start at 0
> > again for the cmd registers.
> >
> > Signed-off-by: Sven Püschel <s.pueschel@xxxxxxxxxxxxxx>
> > ---
> >   drivers/media/platform/rockchip/rga/Makefile  |   2 +-
> >   drivers/media/platform/rockchip/rga/rga.c     |   4 +
> >   drivers/media/platform/rockchip/rga/rga.h     |   2 +-
> >   drivers/media/platform/rockchip/rga/rga3-hw.c | 490 ++++++++++++++++++++++++++
> >   drivers/media/platform/rockchip/rga/rga3-hw.h | 186 ++++++++++
> >   5 files changed, 682 insertions(+), 2 deletions(-)
> Your order of patches is a mess. DTS cannot be in the middle. In fact,
> DTS should not be even in this patchset, because you are targeting media.

sorry to bother you, but could you go into a bit more detail on how it 
should be done correctly?

I guess that your message refers to "7. [...] If a driver subsystem 
maintainer prefers to apply entire set, instead of their relevant 
portion of patchset, please split the DTS patches into separate patchset 
with a reference in changelog or cover letter to the bindings submission 
on the mailing list." [1]. If this is the case, is there a general rule 
to determine if a separate patchset is necessary? (I've also noticed, 
that I've wrongly assumed to keep the Documentation and dtsi commit 
together and should've moved the dtsi commit to the end of the patchset)

And do I understand it correctly, that the Documentation/ change is at 
the correct position (only the dtsi commits being problematic)? Based on 
my understanding of "5. The Documentation/ portion of the patch should 
come in the series before the code implementing the binding" [1] this 
should be right before the actual implementation (after all cleanup and 
preparation commits).


Sincerely
    Sven


[1] 
https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html

> Best regards,
> Krzysztof