Re: [PATCH v2] serial: 8250_pcilib: Replace deprecated PCI functions

[Florian Eckert]

On 2025-10-02 07:25, Greg KH wrote:
> On Wed, Oct 01, 2025 at 04:45:44PM +0200, Florian Eckert wrote:
> > On 2025-09-30 09:34, Jiri Slaby wrote:
> > > On 30. 09. 25, 9:27, Florian Eckert wrote:
> > > > When the '8250_exar' module is loaded into the kernel, a kernel trace
> > > > with 'WARN_ON(legacy_iomap_table[bar])' is dumped to the console,
> > > > because the old pci table mapping is still used in '8250_pcilib'.
> > > >
> > > > The old function have been deprecated in commit e354bb84a4c1 ("PCI:
> > > > Deprecate pcim_iomap_table(), pcim_iomap_regions_request_all()").
> > > >
> > > > The remapping already takes or must take place in the driver that
> > > > calls
> > > > the function 'serial8250_pci_setup_port()'. The remapping should
> > > > only be
> > > > called once via 'pcim_iomap()'. Therefore the remapping moved to the
> > > > caller of 'serial8250_pci_setup_port()'.
> > > >
> > > > To replace the outdated/legacy iomap_table processing in
> > > > '8250_pcilib' the
> > > > function signature of 'serial8250_pci_setup_port()' has been
> > > > extended with
> > > > an already iomapped address value. So this can be used directly
> > > > without
> > > > io mapping again.
> > > >
> > > > Signed-off-by: Florian Eckert <fe@xxxxxxxxxx>
> > > > ---
> > > >
> > > > v2:
> > > > * The function 'pcim_iomap()' returns a NULL pointer in the event of
> > > > an
> > > >    error, so error handling has been adjusted.
> > >
> > > LGTM now.
> > >
> > > Reviewed-by: Jiri Slaby <jirislaby@xxxxxxxxxx>
> >
> > Thanks for the review tag. Will this be included in linux next?
> > Or do I need to do something? I also think that this should be 
> > backportet
> > to the latest LTS kernel “6.12.*”. This is where I noticed the 
> > problem.
>
> The merge window is currently happening, I can't add any changes to my
> tree until after that closes in 1 1/2 weeks.  And if you need/want it
> backported to stable kernels, can you provide a "Fixes:" tag and a cc:
> stable tag as well?

Thanks for the info. I'll wait until the change has been applied to your
master branch. After that I will send a backport patch for LTS 6.12.

Thanks

--
Florian