Re: [PATCH] sound/soc/codecs/wm8978: add missing BCLK divider setup
From: Charles Keepax
Date: Tue Oct 07 2025 - 08:27:13 EST
On Tue, Oct 07, 2025 at 01:18:02PM +0100, Mark Brown wrote:
> On Tue, Oct 07, 2025 at 01:11:24PM +0100, Charles Keepax wrote:
>
> > Its not missing its right there. That said your way is probably
> > slightly more standard these days, but we should take care of the
> > interaction between the two.
>
> Where we've had users using the manual divider configuration that we
> cared about in the past we've suppressed automatic configuration if
> manual configuration has ever been done by the machine driver.
I don't see any current users for the manual divider configuration
at least in mainline, so we could probably just drop the manual
stuff. I don't think I have a strong opinion between that
and blocking the automatic configuration if it was previously
set manually, but we should do one of them to keep things clear.
Thanks,
Charles