Re: [PATCH v4 1/4] arm64: dts: rk3399-pinephone-pro: Add light/proximity sensor support

[Rudraksha Gupta]

Hello Diederik,

> > +	stk3311 {
> > +		stk3311_int: stk3311-int {
> > +			rockchip,pins = <4 RK_PD3 RK_FUNC_GPIO &pcfg_input_pull_up>;
> On page 11 and 17 of PPP schematic V1.0-20211127 I see LIGHT_INT_L as
> identifier so it's best to use that identifier here, thus
> ``light_int_l: light-int-l {``
> and update the pinctrl-0 reference accordingly.
Thanks! Since this is a simple change, I will wait for more comments in 
this patch series (would like comments on the mount matrices for the 
accelerometer and the magnetometer). I will put this change in v5 if I 
send one.


Thanks,

Rudraksha