Re: [PATCH 1/2] dt-bindings: sound: qcom,sm8250: add QRB2210 and RB1 soundcards

[Krzysztof Kozlowski]

On 07/10/2025 10:26, Alexey Klimov wrote:
> Add soundcard compatible for QRB2210 (QCM2290) platforms.
> While at this, also add QRB2210 RB1 entry which is set to be
> compatible with QRB2210 soundcard.


You explained here what you did, but you should explain why. I don't
quite get why SoC sound card and RB1 sound card are both needed. I would
just go with one.

Please use subject prefixes matching the subsystem. For bindings, the
preferred subjects are explained here:
https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters

> 


Best regards,
Krzysztof