Re: [PATCH v1 4/4] dt-bindings: phy: google: Add Google SoC USB PHY

[Krzysztof Kozlowski]

On 07/10/2025 08:21, Roy Luo wrote:
> Document the USB PHY bindings for Google Tensor SoCs.
> 
> Signed-off-by: Roy Luo <royluo@xxxxxxxxxx>
> ---
>  .../bindings/phy/google,usb-phy.yaml          | 91 +++++++++++++++++++
>  1 file changed, 91 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/phy/google,usb-phy.yaml
> 
> diff --git a/Documentation/devicetree/bindings/phy/google,usb-phy.yaml b/Documentation/devicetree/bindings/phy/google,usb-phy.yaml
> new file mode 100644
> index 000000000000..5552696edfff
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/phy/google,usb-phy.yaml
> @@ -0,0 +1,91 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +# Copyright (C) 2025, Google LLC
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/phy/google,usb-phy.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Google USB PHY
> +
> +maintainers:
> +  - Roy Luo <royluo@xxxxxxxxxx>
> +
> +description:
> +  Describes the USB PHY block on Google Tensor SoCs.

Which ones? You need to be VERY specific here.

> +
> +properties:
> +  compatible:
> +    items:
> +      - enum:
> +          - google,lga-usb-phy
> +      - const: google,usb-phy

Please read carefully  bindings. You cannot have generic compatible.
Plus you are duplicating existing Samsung bindings.

Best regards,
Krzysztof