Re: [PATCH net] net: usb: lan78xx: fix use of improperly initialized dev->chipid in lan78xx_reset

From: Jakub Kicinski

Date: Mon Oct 06 2025 - 14:12:13 EST


On Wed, 1 Oct 2025 18:44:09 +0530 I Viswanath wrote:
> dev->chipid is used in lan78xx_init_mac_address before it's initialized:
>
> lan78xx_reset() {
> lan78xx_init_mac_address()
> lan78xx_read_eeprom()
> lan78xx_read_raw_eeprom() <- dev->chipid is used here
>
> dev->chipid = ... <- dev->chipid is initialized correctly here
> }
>
> Reorder initialization so that dev->chipid is set before calling
> lan78xx_init_mac_address().

We need a Fixes tag
--
pw-bot: cr