Re: [PATCH v6 0/4] hide ->i_state behind accessors
From: Mateusz Guzik
Date: Mon Oct 06 2025 - 09:16:40 EST
On Mon, Oct 6, 2025 at 1:38 PM Christian Brauner <brauner@xxxxxxxxxx> wrote:
>
> On Mon, Sep 29, 2025 at 02:56:23PM +0200, Mateusz Guzik wrote:
> > This was a stripped down version (no lockdep) in hopes of getting into
> > 6.18. It also happens to come with some renames.
>
> That was not obvious at all and I didn't read that anywhere in the
> commit messages?
>
Well I thought I made it clear in the updated cover letter, we can
chalk it up to miscommunication. Shit happens.
> Anyway, please resend on top of vfs-6.19.inode where I applied your
> other patches! Thank you!
I rebased the patchset on top of vfs-6.19.inode and got a build failure:
fs/ocfs2/super.c:132:27: error: ‘inode_just_drop’ undeclared here (not
in a function)
132 | .drop_inode = inode_just_drop,
| ^~~~~~~~~~~~~~~
and sure enough the commit renaming that helper is missing. Can you
please rebase the branch?