Re: [PATCH 3/3] drm/panel: Add Novatek NT36532 panel driver

From: Dmitry Baryshkov

Date: Mon Oct 06 2025 - 06:02:31 EST


On Mon, Oct 06, 2025 at 11:24:35AM +0200, Konrad Dybcio wrote:
> On 10/2/25 4:04 AM, Dmitry Baryshkov wrote:
> > On Wed, Oct 01, 2025 at 09:59:14PM +0800, Junjie Cao wrote:
> >> Add a driver for panels using the Novatek NT36532 Display Driver IC,
> >> including support for the CSOT PPC100HB1-1, found in the OnePlus Pad 2
> >> tablets.
> >>
> >> Signed-off-by: Junjie Cao <caojunjie650@xxxxxxxxx>
> >> ---
> >> MAINTAINERS | 7 +
> >> drivers/gpu/drm/panel/Kconfig | 10 +
> >> drivers/gpu/drm/panel/Makefile | 1 +
> >> drivers/gpu/drm/panel/panel-novatek-nt36532.c | 437 ++++++++++++++++++
> >> 4 files changed, 455 insertions(+)
> >> create mode 100644 drivers/gpu/drm/panel/panel-novatek-nt36532.c
> >>
> >> +
> >> +static const struct panel_info csot_panel_info = {
> >> + .width_mm = 250,
> >> + .height_mm = 177,
> >> + .lanes = 4,
> >> + .format = MIPI_DSI_FMT_RGB888,
> >> + .mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_CLOCK_NON_CONTINUOUS |
> >> + MIPI_DSI_MODE_LPM,
> >> + .display_mode = csot_display_mode,
> >> + .dsc_slice_per_pkt = 2,
> >
> > As this is not a part of the standard, what if the DSI host doesn't
> > support this feature?
>
> Shouldn't the core gracefully throw something like an -EINVAL?

There is no 'core' here. Each DSI DRM host manages DSC on their own.

--
With best wishes
Dmitry