Re: [PATCH v2 4/5] kbuild: uapi: upgrade check_sizetypes() warning to error

[Geert Uytterhoeven]

Hi Thomas,

On Fri, 15 Aug 2025 at 03:26, Thomas Weißschuh
<thomas.weissschuh@xxxxxxxxxxxxx> wrote:
> No problematic type usages exist anymore.
>
> Make sure it stays this way.
>
> Signed-off-by: Thomas Weißschuh <thomas.weissschuh@xxxxxxxxxxxxx>
> Reviewed-by: Nicolas Schier <nsc@xxxxxxxxxx>

Thanks for your patch, which is now commit c3a9d74ee413bdb3 ("kbuild:
uapi: upgrade check_sizetypes() warning to error") upstream,

> --- a/usr/include/headers_check.pl
> +++ b/usr/include/headers_check.pl
> @@ -159,7 +159,6 @@ sub check_sizetypes
>                               "found __[us]{8,16,32,64} type " .
>                               "without #include <linux/types.h>\n";
>                 $linux_types = 2;
> -               # Warn until headers are all fixed
> -               #$ret = 1;
> +               $ret = 1;
>         }
>  }

Unfortunately not all of them have been fixed.
On m68k all{yes,mod}config:

    usr/include/asm/bootinfo-amiga.h:18: found __[us]{8,16,32,64} type
without #include <linux/types.h>
    make[6]: *** [usr/include/Makefile:89:
usr/include/asm/bootinfo-amiga.hdrtest] Error 1

As this is a false positive, I have sent a fix for headers_check.
"[PATCH] kbuild: uapi: Strip comments before size type check"
https://lore.kernel.org/6e68ab921a728caea4f3f37bfae9b1896edfa97a.1759740354.git.geert@xxxxxxxxxxxxxx

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds